Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed Nav Container plugin and fixed Navigation Link plugin #192

Merged
merged 39 commits into from
Mar 21, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Feb 28, 2024

Description

This PR

  • Removes the Nav Container plugin. Its functionality has already been taken over by the "Container" option of the Navigation plugin. The template code has been moved to the Navigation plugin effectively re-enabling the responsiveness of Bootstrap 5 navbar: On small viewports the navbar automatically collapses.
  • The navigation link does now render icons
  • Improved support for RTL setups

Related issues

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.78%. Comparing base (f11feee) to head (37fac26).
Report is 6 commits behind head on master.

Files Patch % Lines
...ontend/contrib/navigation/frameworks/bootstrap5.py 0.00% 1 Missing and 1 partial ⚠️
djangocms_frontend/contrib/navigation/models.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   86.93%   86.78%   -0.16%     
==========================================
  Files         120      120              
  Lines        3107     3109       +2     
  Branches      330      331       +1     
==========================================
- Hits         2701     2698       -3     
- Misses        304      307       +3     
- Partials      102      104       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit 7b97985 into django-cms:master Mar 21, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant